[MNG-6774] - Speedup project graph build by paralleling operations #290
Conversation
|
Cool. |
|
Hi I also tested apache wicket and results are follwing: New -T1 New -T2 New -T4 New -T8 |
|
Hello, any update on this? |
|
Sorry. |
There was a problem hiding this comment.
Great work.
I left a few comments
We are going to move master to java 8 so we could use lambda but we have to wait for @rfscholte commit
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
Outdated
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
Outdated
Show resolved
Hide resolved
using fork join pool to build graph
|
rebased on top of current master (3.7.0-SNAPSHOT) |
|
any updates please, when it can be merged ? |
Initial implementation of DefaultGraphBuilder is single threaded and doesn't scale on multi-core servers/workstations.
The proposal is to use fork join pool to build the project graph - as per initial result, graph build time reduced ~2.5 times with -T4 from 14..15 to 5..6 sec
Implementation is rather trivial - current implementation walks projects tree in depth which is naturally fits fork join model - sub-modules are forked and joined to get final result
Risks: mostly mutable objects in domain model and non-functional initial implementation.
Safety could be improved with model rework to immutable model.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.